Skip to content
This repository has been archived by the owner on Nov 11, 2018. It is now read-only.

[DO NOT PULL] Issue #7 Selection and Copy #389

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Eugene-msc
Copy link

This is a second pull request on the same subject because I screwed up with my git branch and did not know how to undo it. I closed the previous one.

This is my implementation of selection and copy.

I made this PR because I am not sure that the way I implemented it is a good one.

It is not yet done and there probably are some bugs, the code is not up to standard and I have concerns about performance.

I was doing it mostly for fun, so if it will be decided to proceed with this implementation I will be working on solving the problems mentioned above.

What works:
Normal selection
Word selection (double click)
Line selection (triple click)
Copy to clipboard

What needs to be done:
Stylable selection
Characters that are considered part of the word should be changeable via settings window (?)
Column selection (? @p-e-w wrote that we can do without it for the time. The bad thing about this implementation is that we will probably need to do some major changes to line creation and wrap system to make column selection work )

PS It will not be too hard to implement sublimetext-like multiple selections. Are there plans for this?

Normal, Word and Line selections. Copy of selected text.
#<Shift>Insert { ~keypad } = SEND_TO_SHELL "\\033[4l"
#<Shift>Insert { keypad } = SEND_TO_SHELL "\\033[2\;2~"
#<Ctrl>Insert { ~keypad } = SEND_TO_SHELL "\\033[L"
#<Ctrl>Insert { keypad } = SEND_TO_SHELL "\\033[2\;5~"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do these lines have to be commented? The "Shift+Insert" shortcut works on my system even with these lines enabled – it's the "Ctrl+Shift+V" shortcut I can't get to work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants