Swift 4.2 support #273
Merged
Swift 4.2 support #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p2
reviewed
Jul 11, 2018
README.md
Outdated
| @@ -4,7 +4,7 @@ OAuth2 | |||
| [](https://travis-ci.org/p2/OAuth2) | |||
| [](LICENSE.txt) | |||
|
|
|||
| OAuth2 frameworks for **macOS**, **iOS** and **tvOS** written in Swift 3.0. | |||
| OAuth2 frameworks for **macOS**, **iOS** and **tvOS** written in Swift 4.0. | |||
| @@ -115,7 +115,7 @@ open class OAuth2WebViewController: UIViewController, WKNavigationDelegate { | |||
| // create a web view | |||
| let web = WKWebView() | |||
| web.translatesAutoresizingMaskIntoConstraints = false | |||
| web.scrollView.decelerationRate = UIScrollViewDecelerationRateNormal | |||
| web.scrollView.decelerationRate = UIScrollView.DecelerationRate.normal | |||
There was a problem hiding this comment.
No because it wouldn't be compatible with 4.0 anymore, and Xcode 10 won't be released for a few months yet.
MaximeLM
pushed a commit
to MaximeLM/OAuth2
that referenced
this pull request
Aug 23, 2018
* Upgrade codebase to support Swift 4.2 * Fix broken tests (order of query parameters is not guaranteed) * Changelog entries for previous PRs and releases
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support Xcode 10 (beta).
The codebase should still be compatible with Swift 4.1 (Xcode 9).
Note: I've also fixed some broken tests (already broken in older Xcode versions) and added a bunch of changelog entries.