Add compiler flag to disable UIApplication calls #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool, thanks! Just 1 thing: can you make an |
|
Done |
|
Thanks! And I just realized, with this compiler flag, we no longer need the comment and the workaround to get the UIApp instance via |
|
Ok, that's done! |
|
Great, thanks! Did you want to add your name as mentioned in CONTRIBUTING.md or shall I merge now? |
|
I've added myself as a contributor, you can merge. |
ajandrade
added a commit
to sensational/OAuth2
that referenced
this pull request
Oct 14, 2020
* commit '0efd11a669aba0f7c8ed2946e93757bb3dfdd6a6': Update Travis config Update project settings and CHANGELOG Improve documentation Fix compilation errors and warnings from PKCE merge Add refresh uri setting (p2#330) Mac Catalyst support (p2#328) Changed autorizeContext var to weak (p2#329) Add PKCE support (p2#324) Update Swift package manager configuration (p2#322) Update to Swift 5 Fix compile errors with Swift 5 (p2#313) Update README.md Add support for Authentication Session (p2#305) Update version in sample configurations of the README to 4.2 Use bundler for generating docs Set podspec version to 4.2.0 Add compiler flag to disable UIApplication calls (p2#280)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #275 with the solution initially proposed in #133.
App extensions users will be able to add a
P2_APP_EXTENSIONScompiler flag to the p2.OAuth2 target to disable UIApplication calls.