Fix handling of non-Data expressions as primitive arguments #888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding support for returning lvalues in the expression evaluation engine (#839), we introduced support for using expressions which do not evaluate to a simple Data value as primitive arguments. In particular, we can use an expression which evaluates to a Header object as a primitive argument. However, the code responsible for parsing the bmv2 input JSON and instantiating Action objects was treating all expressions used as primitive arguments as "Data expressions", thus causing bmv2 to crash when it was actually not the case. Fixes #887
antoninbas
deleted the
antonin/fix-handling-of-non-data-expressions-as-action-args
branch
antoninbas
added a commit
that referenced
this pull request
May 11, 2020
A recent fix for a separate issue (#888) exposed a separate bug: the type of expressions for which the top-level operator was "access_field" was not deduced properly (set to UNKNOWN instead of DATA), which caused bmv2 to assert when building the Action object. The same issue existed for "access_union_header", which is an operator introduced more recently (and possibly not used by p4c yet). Fixes #889
antoninbas
added a commit
that referenced
this pull request
May 11, 2020
A recent fix for a separate issue (#888) exposed a separate bug: the type of expressions for which the top-level operator was "access_field" was not deduced properly (set to UNKNOWN instead of DATA), which caused bmv2 to assert when building the Action object. The same issue existed for "access_union_header", which is an operator introduced more recently (and possibly not used by p4c yet). Fixes #889
antoninbas
added a commit
that referenced
this pull request
May 11, 2020
A recent fix for a separate issue (#888) exposed a separate bug: the type of expressions for which the top-level operator was "access_field" was not deduced properly (set to UNKNOWN instead of DATA), which caused bmv2 to assert when building the Action object. The same issue existed for "access_union_header", which is an operator introduced more recently (and possibly not used by p4c yet). Fixes #889
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding support for returning lvalues in the expression evaluation
engine (#839), we
introduced support for using expressions which do not evaluate to a
simple Data value as primitive arguments. In particular, we can use an
expression which evaluates to a Header object as a primitive
argument. However, the code responsible for parsing the bmv2 input JSON
and instantiating Action objects was treating all expressions used as
primitive arguments as "Data expressions", thus causing bmv2 to crash
when it was actually not the case.
Fixes #887