Specify key names generated for keys with masks

[mihaibudiu]

Signed-off-by: Mihai Budiu mbudiu@vmware.com
Fixes #1138
This has been supported by the compiler for at least 5 years.

[apinski-cavium]

I assume you double checked that there was no other expressions missing from that table the compiler supports too?
Note I am only getting to the table and control plane parts of the specifications for my compiler so I am happy for this change, I just want to make sure I don't miss any others here.

[mihaibudiu]

This is the signature of the corresponding pass:

class KeyNameGenerator : public Inspector {
    void postorder(const IR::Expression* expression) override;
    void postorder(const IR::PathExpression* expression) override;
    void postorder(const IR::Member* expression) override;
    void postorder(const IR::ArrayIndex* expression) override;
    void postorder(const IR::Constant* expression) override;
    void postorder(const IR::Slice* expression) override;
    void postorder(const IR::BAnd* expression) override;
    void postorder(const IR::MethodCallExpression* expression) override;
};

MethodCallExpression is for isValid.

[mihaibudiu]

We should verify what various implementations do.
What is the authoritative name? The p4info file?

[mihaibudiu]

@vgurevich will post comments.

[mihaibudiu]

The Barefoot compiler does not use these rules for masks and slices.

[jafingerhut]

is -> it?

[jafingerhut]

Looks reasonable to me.

[jafingerhut]

LGTM