Fix bug in type inference for constructor arguments

Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
p4lang · Nov 18, 2022 · fabd91c · fabd91c
1 parent 747d2d7
commit fabd91c
Showing 1 changed file with 15 additions and 0 deletions.
diff --git a/frontends/p4/typeChecking/typeChecker.cpp b/frontends/p4/typeChecking/typeChecker.cpp
@@ -1021,6 +1021,21 @@ TypeInference::checkExternConstructor(const IR::Node* errorPosition,
     if (!functionType->is<IR::Type_Method>())
         BUG("Unexpected type for function %1%", functionType);
 
+    LOG2("Constructor type before specialization " << methodType << " with " << tvs);
+    TypeVariableSubstitutionVisitor substVisitor(tvs);
+    substVisitor.setCalledBy(this);
+    auto specMethodType = methodType->apply(substVisitor);
+    LOG2("Constructor type after specialization " << specMethodType);
+    learn(specMethodType, this);
+    auto canon = getType(specMethodType);
+    if (canon == nullptr)
+        return nullptr;
+
+    auto functionType = specMethodType->to<IR::Type_MethodBase>();
+    BUG_CHECK(functionType != nullptr, "Method type is %1%", specMethodType);
+    if (!functionType->is<IR::Type_Method>())
+        BUG("Unexpected type for function %1%", functionType);
+
     ConstantTypeSubstitution cts(tvs, refMap, typeMap, this);
     // Arguments may need to be cast, e.g., list expression to a
     // header type.