Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up to issue 2104, exit also kills all variables #2151

Closed
fruffy opened this issue Jan 23, 2020 · 3 comments
Closed

Follow-up to issue 2104, exit also kills all variables #2151

fruffy opened this issue Jan 23, 2020 · 3 comments
Assignees
@mihaibudiu
Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.

Comments

@fruffy
Copy link
Collaborator

fruffy commented Jan 23, 2020 •
edited
Loading

A follow up to a previous bug. In issue #2104 return statements killed all subsequent variables. This also happens with exit statements, we missed to cover these.
2151.txt
@mihaibudiu
Copy link
Contributor

If you have a program that crashes the compiler can you please post it?

@fruffy
Copy link
Collaborator Author

fruffy commented Jan 24, 2020

Attached.

@mihaibudiu
Copy link
Contributor

The sad thing is that the fix for #2104 does handle exit statements. But, obviously, this is not good enough.

@mihaibudiu mihaibudiu self-assigned this Jan 24, 2020
@mihaibudiu mihaibudiu added the bug This behavior is unintended and should be fixed. label Jan 24, 2020
mihaibudiu pushed a commit to mihaibudiu/p4c-clone that referenced this issue Jan 28, 2020
Exit makes statements unreachable; fixes p4lang#2151
65aca94
@mihaibudiu mihaibudiu added the fixed This topic is considered to be fixed. label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mihaibudiu mihaibudiu

Labels
bug This behavior is unintended and should be fixed. fixed This topic is considered to be fixed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fruffy @mihaibudiu