Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate function after casting #2404

Merged
merged 1 commit into from
Jun 9, 2020
Merged

Evaluate function after casting #2404

merged 1 commit into from
Jun 9, 2020

Conversation

mihaibudiu
Copy link
Contributor

Fixes #2392

@mihaibudiu mihaibudiu mentioned this pull request Jun 8, 2020
Merged
antoninbas
antoninbas approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@antoninbas antoninbas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a little review :)
LGTM

@mihaibudiu mihaibudiu merged commit 056c4bb into p4lang:master Jun 9, 2020
@mihaibudiu mihaibudiu deleted the issue2392 branch June 9, 2020 00:46
jnfoster
jnfoster reviewed Jun 9, 2020
View reviewed changes
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Late to the game but LGTM too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster left review comments

@antoninbas antoninbas antoninbas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Question on comparison to negative constants
3 participants
@mihaibudiu @jnfoster @antoninbas