loop_revisit method for dealing with recursive loops in the IR #3106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even DAGs cause difficulties today, allowing loops will make reasoning about the flow of control much harder. |
mihaibudiu
approved these changes
Mar 2, 2022
- by default will BUG("IR loop detected") (the old behavior), but allows
writing visitor passes that can override and deal with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
writing visitor passes that can override and deal with it.
This is an experimental infrastructure extension that is most useful with the ResolutionContext/apply with context param stuff added awhile back -- using that code, a visitor can look up symbols and recursively visit the definition of the symbol, but doing so may lead to loops in the traversal. This change allows dealing with those resulting loops rather than just exiting with a BUG (though that is still the default behavior) by overriding the loop_revisit method in the Visitor subclass.