sfinae-protect operator== StringRef overload #3132
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encountered a c++ compilation issue when using p4c together with inja (https://github.com/pantor/inja) in one project. Inja headers define:
which is supposed to be called when
basic_string_view<>
is compared toconst char*
. But if p4c sources are also included, such call is ambiguous, becauseoperator==(T, StringRef)
also participates in overload resolution:This PR fixes this problem by employing SFINAE to enable
operator==(T a, StringRef b)
only ifa == b
is a valid expression.