typeChecker: make error message less confusing #3152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same error message was used for all struct-like types: * IR::Type_UnknownStruct * IR::Type_Struct * IR::Type_Header * IR::Type_HeaderUnion In case of a header or header_union it could result in a message like this: """ Field my_field is not a member of structure header my_header_h """ which might have been confusing for a user (why is error message mentioning structure and header at one place?). The word "structure" is now omitted in case of IR::Type_Header and IR::Type_HeaderUnion. String representation of IR::Type_Header and IR::Type_HeaderUnion nodes used in this error message already contains also header or header_union keyword.
mvido
force-pushed
the
mvido/type_check_error_message
branch
from
299ea18 to
28643cd
Compare
mihaibudiu
approved these changes
Mar 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same error message was used for all struct-like types:
In case of a header or header_union it could result in a message
like this:
"""
Field my_field is not a member of structure header my_header_h
"""
which might have been confusing for a user (why is error message
mentioning structure and header at one place?).
The word "structure" is now omitted in case of IR::Type_Header
and IR::Type_HeaderUnion.
String representation of IR::Type_Header and IR::Type_HeaderUnion
nodes used in this error message already contains also header or
header_union keyword.