Add --xdp2tc compiler flag for eBPF backend #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mateusz Kossakowski <mateusz.kossakowski@orange.com> Co-authored-by: Jan Palimąka <jan.palimaka@orange.com>
mihaibudiu
approved these changes
Apr 7, 2022
backends/ebpf/ebpfOptions.cpp
Outdated
| } | ||
| return true; | ||
| }, | ||
| "[psa only] Select the mode used to pass metadata from XDP to TC."); |
There was a problem hiding this comment.
This needs a longer description, no one will guess the possible choices.
| metadata. In this mode, the helper must be invoked twice - in the XDP helper program to append the metadata and in | ||
| the TC Ingress to strip the metadata out of a packet. We also introduce the third mode - `cpumap`, which is an experimental features and should be used carefully. | ||
| The `cpumap` assumes that the single CPU core handles a packet in the run-to-completion mode from XDP up to the TC layer | ||
| (in other words, for a given packet, the CPU core running the TC program is the same as the one for XDP). If the above |
There was a problem hiding this comment.
wonder whether you can check this somehow dynamically and abort if it's not true.
There was a problem hiding this comment.
Not really. We could check if, for instance, RPS/RFS is enabled, but still a P4 program may be compiled on a remote machine (other than the one where a compiled eBPF program is deployed).
|
@mbudiu-vmw I've fixed cpplint and synced with main to avoid Fedora build issues. Should be ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the XDP2TC mode configurable. The XDP2TC mode determines how the metadata (containing original EtherType) is passed from XDP up to TC. This is needed because we discovered that the default
metamode usingbpf_xdp_adjust_meta()is not supported by some NIC drivers. In such a case, the entire PSA implementation for eBPF does not work. This PR adds two alternative modes:headandcpumapthat can be used to work around the NIC limitations.