P4C-DPDK - Support Non-zero arguments for default action #3206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-sajan
force-pushed
the
non-zero-arg-def-action
branch
2 times, most recently
from
7d83448 to
8fb256b
Compare
mihaibudiu
requested changes
Apr 11, 2022
backends/dpdk/dpdkArch.cpp
Outdated
| BUG_CHECK(mi->is<P4::ActionCall>(), | ||
| "%1%: expected action in default_action", default_action); | ||
| auto new_l = new IR::IndexedVector<IR::Parameter>; | ||
| for (auto p : mi->to<P4::ActionCall>()->action->parameters->parameters) { |
There was a problem hiding this comment.
why can't you just keep a pointer to the list itself?
| if (earg->is<IR::ListExpression>()) { | ||
| auto paramCount = earg->to<IR::ListExpression>()->components.size(); | ||
| for (unsigned i = 0; i < paramCount; i++) { | ||
| if (earg->to<IR::ListExpression>()->components.at(i)->is<IR::Constant>()) { |
There was a problem hiding this comment.
so if the argument is not a numeric constant what should happen?
github-sajan
force-pushed
the
non-zero-arg-def-action
branch
from
8fb256b to
48889bc
Compare
github-sajan
force-pushed
the
non-zero-arg-def-action
branch
from
48889bc to
9aaa5f4
Compare
mihaibudiu
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.