DPDK Backend: Minor fix to emit target_action_name in context json #3213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanw
reviewed
Apr 13, 2022
| "description": "Name of the action" | ||
| "description": "Name of the action as in P4 file" | ||
| }, | ||
| "target_action_name": { |
There was a problem hiding this comment.
Who consumes the internal action name, just curious.
There was a problem hiding this comment.
Pipe manager will query the action handle in dpdk target to associate with context.json action handle. For this it needs to use the same name as the name in the spec file.
In the spec file, we use the internal names as the originalName is modified by the frontend in some cases to uniquify them and causes a mismatch between action name in action definition and the one in the table action list.
mihaibudiu
approved these changes
Apr 13, 2022
|
@mbudiu-vmw @hanw Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add a new field to context json. This field holds the unique internal name of the actions .This name should be same as the action name in output spec file.
Context json would now contain two fields for the action name, one name is the externalName and should be same as in bfrt json file and another name "target_action_name" should be same as the name in the spec file.
NoAction is handled in special manner to always use the externalName().
Note: Context json files are not part of the repo, hence attaching the patch to show the change. Also attaching bfrt.json and spec file for reference.
pna-example-tunnel.p4.bfrt.json.txt
pna-example-tunnel.p4.spec.txt
Report.txt