Correctly handle don't care named arguments #3278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
approved these changes
May 6, 2022
|
I started to make some changes to improve the quality of the generated code, which turned into something bigger. I will split this into two PRs, a small one here with correct outputs and another one which improves code quality by running def-use after inlining again. |
added 5 commits
May 11, 2022 12:41
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
…shared the IR tree Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
github-sajan
pushed a commit
to github-sajan/p4c
that referenced
this pull request
May 26, 2022
* Correctly handle don't care named arguments * def-use analysis requires all statements (including Empty) not to be shared the IR tree Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Mihai Budiu mbudiu@vmware.com
Fixes #3274
This also fixes a bug where functions were considered to be side-effect-free if they had all parameters 'in'. That is wrong, such a function can still call extern functions that have side-effects.