Add generic structs to P4Runtime digest example #3332
Conversation
To show how they are represented in the P4Info.
|
Hi @antoninbas, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes: ✒️ 👉 https://cla.opennetworking.org After signing, make sure to add your Github user ID For more information or help:" |
| bit<32> f; | ||
| } | ||
|
|
||
| @name("s3_t") struct s3_t_0 { |
There was a problem hiding this comment.
@mbudiu-vmw I don't know if that was discussed at the time of adding generic structs, but this is a bit problematic. It's easy to shoot yourself in the foot as all generated structs will have the same annotation, and the P4Info will actually remove all of the conflicting definitions save for one (so the P4Info will be incorrect).
There was a problem hiding this comment.
no, the interaction between generic structs and the control plane was never discussed.
To show how they are represented in the P4Info.
To show how they are represented in the P4Info.