Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete keys that are empty tuples #3489

Merged
merged 2 commits into from
Aug 17, 2022
Merged

Delete keys that are empty tuples #3489

merged 2 commits into from
Aug 17, 2022

Conversation

mihaibudiu
Copy link
Contributor

Signed-off-by: Mihai Budiu mbudiu@vmware.com

This brings the implementation in line with the spec: p4lang/p4-spec#1132

Delete keys that are empty tuples
8127615 
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@mihaibudiu mihaibudiu requested a review from jafingerhut August 17, 2022 20:56
jafingerhut
jafingerhut approved these changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I tested earlier and so no difference between explicit key = {} tables and those without a key property at all, but this change certainly looks like it should guarantee that it remains this way. Thanks.

Changed reference outputs
431d5d6 
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@mihaibudiu mihaibudiu merged commit c7b90df into p4lang:main Aug 17, 2022
@mihaibudiu mihaibudiu deleted the deletekey branch August 17, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jafingerhut jafingerhut jafingerhut approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mihaibudiu @jafingerhut