-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra toP4 whitespace #3606
Conversation
f2266c1
to
b137f5f
Compare
1b59e8e
to
20eb355
Compare
I looked over the changed test programs in the p4_16_samples directory of this PR. It appears that basically these test programs included v1model.p4, but were not written to use the v1model architecture, and your changes modify them so that they do use the v1model architecture. I did not carefully check the original reason that these test programs were written. It would be good if we did not unintionally change the reason they were created, and what cases within the compiler's implementation that they cover. If these changes did happen to do that, another possible change to the test program would be to no longer include the v1model.p4 file. |
I chose to make them complete v1model programs to add more test cases for the behavioral model (still missing the extension). However, just removing the include also works. I will also move those files to a separate PR since the diff has blown up. |
20eb355
to
158d292
Compare
Migrated the test file cleanup to #3608. |
ad166a3
to
8cb4b31
Compare
d141344
to
6366dd1
Compare
Fixes
toP4
's extra whitespace that is added at the end of the program and after annotations. This PR changes lots of files, spot checking will be necessary.