Rename psabpf repository into NIKSS #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the latest version of `psabpf` we have changed its name to `NIKSS` (Native In-Kernel SDN Switch) as well the location of repository to https://github.com/NIKSS-vSwitch/nikss (old link should still work, but it is recommended to use new one).
mihaibudiu
approved these changes
Nov 8, 2022
| @@ -124,15 +124,15 @@ def setUp(self): | |||
| self.dataplane = ptf.dataplane_instance | |||
| self.dataplane.flush() | |||
|
|
|||
| self.exec_ns_cmd("psabpf-ctl pipeline load id {} {}".format(TEST_PIPELINE_ID, self.test_prog_image), "Can't load programs into eBPF subsystem") | |||
| self.exec_ns_cmd("nikss-ctl pipeline load id {} {}".format(TEST_PIPELINE_ID, self.test_prog_image), "Can't load programs into eBPF subsystem") | |||
There was a problem hiding this comment.
Maybe the name should be in a variable
There was a problem hiding this comment.
We do not plan in the future rename(s) of the repository and that executable, so I think that there is no need for such variable. I mean I would keep as is for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the latest version of
psabpfwe have changed its name toNIKSS(Native In-Kernel SDN Switch) as well the location of repository to https://github.com/NIKSS-vSwitch/nikss (old link should still work, but it is recommended to use new one).