P4Tools: Unify packet sizing options. #3695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/min_max_pkts
branch
3 times, most recently
from
2df7168 to
03ca932
Compare
fruffy
requested review from
pkotikal,
vhavel,
jnfoster and
mihaibudiu
as code owners
pkotikal
approved these changes
Nov 22, 2022
fruffy
force-pushed
the
fruffy/min_max_pkts
branch
from
2772480 to
9862070
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate several packet sizing options into one. Packet sizes are now defined as range (
[min]:[max]). The maximum packet size is now jumbo frame size (9000 byte). Extensions which do not support this size will have to override or implement their own checks (see the eBPF back end).Fixes #3559.