Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternate strength reduction and constant folding to eliminate constants #3706

Merged
merged 3 commits into from
Nov 20, 2022

Conversation

mihaibudiu
Copy link
Contributor

@mihaibudiu mihaibudiu commented Nov 19, 2022

Fixes #3702

Signed-off-by: Mihai Budiu mbudiu@vmware.com

…nt nested shift operations

Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@mihaibudiu mihaibudiu changed the title Alternate strength reduction and constant folding to eliminate consta… Alternate strength reduction and constant folding to eliminate constants Nov 19, 2022
Copy link

@jfingerh jfingerh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test program and expected output files look good to me. As usual, I am not attempting to review the changes to the compiler internals. I did check out the code of this PR's branch and compiled it locally, and verified that there was no non-0 exit status when compiling the original test program that causes a non-0 exit status without these changes.

Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test program and expected output files look good to me. As usual, I am not attempting to review the changes to the compiler internals. I did check out the code of this PR's branch and compiled it locally, and verified that there was no non-0 exit status when compiling the original test program that causes a non-0 exit status without these changes.

Mihai Budiu added 2 commits November 19, 2022 10:07
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
Signed-off-by: Mihai Budiu <mbudiu@vmware.com>
@jafingerhut jafingerhut merged commit 6e856bd into p4lang:main Nov 20, 2022
@mihaibudiu mihaibudiu deleted the issue3702 branch November 21, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bmv2 backend segfaults on parser expressions
3 participants