Run IWYU across the entire compiler code base. #3767
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/iwyu
branch
4 times, most recently
from
d041d1c to
386408d
Compare
fruffy
force-pushed
the
fruffy/iwyu
branch
2 times, most recently
from
ff483a5 to
86d026e
Compare
fruffy
force-pushed
the
fruffy/iwyu
branch
4 times, most recently
from
1b62418 to
cc7fbe8
Compare
fruffy
changed the title
fruffy
force-pushed
the
fruffy/iwyu
branch
5 times, most recently
from
24c89fe to
dc3a882
Compare
Merged
fruffy
force-pushed
the
fruffy/iwyu
branch
3 times, most recently
from
532b84c to
b36412d
Compare
fruffy
added
the
infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up the compiler includes by running IWYU across them. This also exposes how some files have a massive amount of includes, some of which may not be necessary.
If requested, I can also add a comment per include which lists why that particular include was added.
Also reduces the size of binaries by a little. For example p4c-bm2-ss 201MB -> 198MB.