Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove execute permissions from nonexecutable files. #3791

Merged
merged 1 commit into from
Dec 20, 2022
Merged

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Dec 19, 2022

No description provided.

@fruffy fruffy changed the title Remove permissions from nonexecutable files. Remove execute permissions from nonexecutable files. Dec 19, 2022
@fruffy fruffy force-pushed the fruffy/permissions branch 5 times, most recently from ae39d61 to d31f552 Compare December 19, 2022 18:17
@fruffy
Copy link
Collaborator Author

fruffy commented Dec 19, 2022

bazelbuild/bazel#8622 breaks Bazel builds. I tried a couple things but it looks like this comes from upstream dependencies. Not sure how to fix yet.

@smolkaj any ideas?

@smolkaj
Copy link
Member

smolkaj commented Dec 19, 2022

Thanks for the ping, we had the same issue in several other repos.
The regression is due to the release of Bazel 6, which made some breaking changes.
As a workaround, we can fix Bazel to version < 5 by adding a .bazelversion file, see bazelbuild/bazel#8622 (comment)

EDIT: I opened a separate PR with the workaround: #3796

@fruffy fruffy force-pushed the fruffy/permissions branch from cd6b77e to 0d744d1 Compare December 20, 2022 08:25
@fruffy fruffy force-pushed the fruffy/permissions branch from 0d744d1 to 0c5e9cc Compare December 20, 2022 09:59
@fruffy fruffy merged commit 4daa228 into main Dec 20, 2022
@fruffy fruffy deleted the fruffy/permissions branch December 20, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants