Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove nondeterminism in P4Testgen. #3839

Merged
merged 1 commit into from
Jan 16, 2023
Merged

Remove nondeterminism in P4Testgen. #3839

merged 1 commit into from
Jan 16, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jan 12, 2023

Use ordered_map instead of std::map to iterate based on insertion order, not key order. This is needed in some cases where pointers are map keys.

@fruffy fruffy force-pushed the fruffy/testgen_randomness branch 3 times, most recently from 471cbc1 to ed0997d Compare January 13, 2023 13:39
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Jan 15, 2023
@fruffy fruffy force-pushed the fruffy/testgen_randomness branch from ed0997d to 9cc5aaf Compare January 16, 2023 13:15
@fruffy fruffy marked this pull request as ready for review January 16, 2023 14:09
@fruffy fruffy merged commit 6c8e85c into main Jan 16, 2023
@fruffy fruffy deleted the fruffy/testgen_randomness branch January 16, 2023 16:03
@davidbolvansky
Copy link
Contributor

@vlstill was fighting with nondeterminism in bf-p4c, maybe he can help you in this area with some tips :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants