Fix warnings in compilation using clang 15

[vlstill]

Newer clang (13+) has some extra warnings for variables that are set and modified (e.g. ++), but their value is never used. With these changes, build passes again with clang 15 and -Werror. I had to suppress the warning in p4parser as it is in generated code.

[vlstill]

This error is spuriously occurring actually quite often :-/ (in Ubuntu 20 this time).

E: Failed to fetch [https://download.opensuse.org/repositories/home:/p4lang/xUbuntu_20.04/./amd64/p4lang-bmv2_1.15.0-3_amd64.deb](https://download.opensuse.org/repositories/home:/p4lang/xUbuntu_20.04/amd64/p4lang-bmv2_1.15.0-3_amd64.deb)  502  Bad Gateway [IP: 195.135.221.134 443]
E: Unable to fetch some archives, maybe run apt-get update or try with --fix-missing?
Fetched 34.6 MB in 8s (4316 kB/s)
Error: Process completed with exit code 100.

It seems like a network issue, I presume this is running on github-managed machines so we can't do much about it, right?

[davidbolvansky]

lgtm.

Newer clang (13+) has some extra warnings for variables that are set and modified (e.g. ++), but their value is never used.

fyi, implemented by me ;)

[vlstill]

fyi, implemented by me ;)

Oh wow :-D, great!