ebpf/PSA: Add support for wide fields in parser value_set #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osinstom
approved these changes
Mar 3, 2023
backends/ebpf/codeGen.cpp
Outdated
Comment on lines
466
to
467
| // FIXME: When select expression from parser supports more than one field then only the first | ||
| // component will taken into account. |
There was a problem hiding this comment.
What exactly do you want to fix here in the future? Please be explicit, like "remove below if" or sth.
Suggested change
| // FIXME: When select expression from parser supports more than one field then only the first | |
| // component will taken into account. | |
| // FIXME: When a select expression from the parser supports more than one field, only the first | |
| // component will be taken into account. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds ability to match fields wider than 64 bits in parser value set.
CC: @osinstom