Dpdk Backend: Strip pipename prefix added to table and extern names for bfrt.json while generating context json #3936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I do not have good enough technical knowledge of the code changes to review them, but I can confirm that with these changes I can run p4c-dpdk on the P4 program in issue #3928 without any Compiler Bug, and it produces a context.json file that appears reasonable. Thanks for the PR. |
mihaibudiu
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For bfrt.json, an additional pipe_name prefix is added to the table and extern names.
Context json uses the table and action ids from p4info. Since the name of table is different when bfrt json is generated whereas when it is not generated, while generating context json, we remove the pipe_name prefix added by the bfrt generator.
Fixes #3928