Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpplint.py to the latest version #3941

Merged
merged 1 commit into from
Mar 28, 2023
Merged

Update cpplint.py to the latest version #3941

merged 1 commit into from
Mar 28, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Mar 26, 2023

New cpplint includes some useful features such as ignoring // NOLINT comments meant for other linters.
It is also required for #3937.

@mihaibudiu
Copy link
Contributor

@ChrisDodd has customized cpplint, so you have to port his changes to this verion.
what is the benefit of upgrading cpplint?

@fruffy
Copy link
Collaborator Author

fruffy commented Mar 27, 2023

@ChrisDodd has customized cpplint, so you have to port his changes to this verion. what is the benefit of upgrading cpplint?

This is the customized version. cpplint.diff tracks the changes of the customization to the latest cpplint.

The update includes PRs such as this one cpplint/cpplint#196, which are useful.

@fruffy fruffy requested review from ChrisDodd and mihaibudiu March 28, 2023 14:46
@fruffy fruffy merged commit ae1a787 into main Mar 28, 2023
@fruffy fruffy deleted the fruffy/cpplint branch March 28, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants