Also include the backend IR files in the ir-generated library file.

[fruffy]

Hopefully fixes #3984.

[fruffy]

There seems to be some non-determinism in the p4c-bm2 json serialization (or json loading?) for Ubuntu 18. Not quite sure what could cause that. Maybe it is using unordered maps?

Edit: Protobuf maps do not necessarily preserve ordering. Could that be the reason?
https://protobuf.dev/programming-guides/proto3/#maps

[antoninbas]

There seems to be some non-determinism in the p4c-bm2 json serialization (or json loading?) for Ubuntu 18. Not quite sure what could cause that. Maybe it is using unordered maps?

Edit: Protobuf maps do not necessarily preserve ordering. Could that be the reason? https://protobuf.dev/programming-guides/proto3/#maps

I don't think the tests in load_ir_from_json.cpp have anything to do with Protobuf. That's IR serialization.

[fruffy]

I don't think the tests in load_ir_from_json.cpp have anything to do with Protobuf. That's IR serialization.

Ah, for some reason I assumed the JSON generated by p4c-bm2-ss is generated using protobuf. But the back end has its own serializer. Makes it even more confusing.

[fruffy]

Turns out ConvertEnums::EnumMapping was not an ordered_map and did not preserve insertion order.

[antoninbas]

Thanks for fixing the build issue

[fruffy]

@mbudiu-vmw @jnfoster @pkotikal Could you rubberstamp this? The PR fixes a build problem, but is blocked because of the codeowners restriction.

[jnfoster]

Rubberstamp'd.

[fruffy]

Thanks!