Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4Testgen] More P4Tools refactoring work. #4005

Merged
merged 2 commits into from
May 16, 2023
Merged

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented May 9, 2023

  • Move TestUtils.cmake from the testgen folder to the top-level folder. This allows other P4Tools modules to use the same test infrastructure.
  • Use the correct folder paths and CMake variables for the CMake test scripts.
  • Remove unnecessary code from the P4Tests.cmake files (There was a double file scan, which made cmake calls unnecessarily slow).
Miscellaneous fixes and improvements
  • Improve some error messages (for example, state variable matching).
  • Add some linter suggestions (capitalization etc).
  • Add some new BMv2 constants.
  • Require a reference instead of a (potentially null) pointer for table utils.

@fruffy fruffy force-pushed the fruffy/core_refactoring branch from d9757eb to 2af20ed Compare May 10, 2023 13:23
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label May 10, 2023
@fruffy fruffy changed the title More P4Tools refactoring work. [P4Testgen] More P4Tools refactoring work. May 10, 2023
@fruffy fruffy force-pushed the fruffy/core_refactoring branch 4 times, most recently from c17a1d6 to 57cc19d Compare May 15, 2023 17:27
@fruffy fruffy force-pushed the fruffy/core_refactoring branch from 57cc19d to 5cff13c Compare May 15, 2023 19:30
@fruffy fruffy marked this pull request as ready for review May 15, 2023 20:53
@fruffy fruffy requested review from pkotikal and jnfoster as code owners May 15, 2023 20:53
@fruffy fruffy merged commit 7b7d799 into main May 16, 2023
@fruffy fruffy deleted the fruffy/core_refactoring branch May 16, 2023 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants