Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4Testgen] Remove execution state from the symbolic executor, make it a parameter. #4031

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

fruffy-bfn
Copy link
Contributor

@fruffy-bfn fruffy-bfn commented Jun 15, 2023

Execution state should only live as long as the run function of the symbolic executor is active. This also makes sure we do not access some stale execution state via the symbolic executor.

This impacts the SelectedBranches implementation, which is now simplified.

@fruffy-bfn fruffy-bfn force-pushed the fruffy/symbex_remove_execution_state branch from 34acc66 to 900340e Compare June 15, 2023 23:29
@fruffy-bfn fruffy-bfn marked this pull request as ready for review June 16, 2023 16:46
@fruffy-bfn fruffy-bfn changed the title Remove execution state from the symbolic executor, make it a parameter. [P4Testgen] Remove execution state from the symbolic executor, make it a parameter. Jun 16, 2023
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Jun 16, 2023
Copy link
Contributor

@jnfoster jnfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. This is a good change.

@fruffy fruffy merged commit d305d3c into p4lang:main Jun 19, 2023
@fruffy-bfn fruffy-bfn deleted the fruffy/symbex_remove_execution_state branch June 19, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants