Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[P4Testgen] Fix an infinite loop in the coverable nodes scanner. #4073

Merged
merged 1 commit into from
Jul 19, 2023
Merged

[P4Testgen] Fix an infinite loop in the coverable nodes scanner. #4073

merged 1 commit into from
Jul 19, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Jul 18, 2023

The parser ID was added too late. If a parser state references itself, the scanner will loop infinitely.

@fruffy fruffy requested review from pkotikal and jnfoster as code owners July 18, 2023 22:00
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Jul 18, 2023
@fruffy fruffy merged commit 7cf4952 into main Jul 19, 2023
@fruffy fruffy deleted the fruffy/fix_coverage_scan_loop branch July 19, 2023 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnfoster jnfoster jnfoster approved these changes

@pkotikal pkotikal Awaiting requested review from pkotikal

Assignees
No one assigned
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fruffy @jnfoster