Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P4Testgen] Do not use Equ for mandating a minimum size. #4154

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented Sep 12, 2023

Fixes #4151. This was a silly bug. Earlier, P4Testgen only had to option to fix packet size to a particular value. After transitioning to ranges, the equality was not converted into a greater-equals relation.

@fruffy fruffy changed the title Do not use equ for mandating a minimum size. [P4Testgen] Do not use Equ for mandating a minimum size. Sep 12, 2023
@fruffy fruffy added the p4tools Topics related to the P4Tools back end label Sep 12, 2023
Copy link
Contributor

@jafingerhut jafingerhut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jafingerhut
Copy link
Contributor

Silly bugs are often the quickest to fix. Thanks!

@fruffy fruffy merged commit 1549c63 into main Sep 12, 2023
@fruffy fruffy deleted the fruffy/testgen_fix_pkt_min_size branch September 12, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tools Topics related to the P4Tools back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

p4testgen errors when giving it min packet length larger than 0 bits
2 participants