-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improved bootstrap.sh #4227
improved bootstrap.sh #4227
Conversation
ba69163
to
1e03440
Compare
ln -sf "$(realpath --relative-to "${link_name_dir}/" "${target}")" "${link_name}" | ||
} | ||
|
||
make_relative_link "${mydir}/.gdbinit" "backends/bmv2/p4c-bm2-psa-gdb.gdb" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is something to instantiate within CMakelists for each back end instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there's a way to do it in cmake, maybe. I've had little luck with getting cmake to set up things like this, and it is not strictly needed for the build. Just nice to have if you run gdb
The MacOS test is failing because of a substitution issue. |
Ugh -- I guess MacOS's bash is not really bash? They don't like GPL'd things. |
1e03440
to
f0edc4e
Compare
f0edc4e
to
48ce16e
Compare
There seem to be some intermittent failures in the dpdk CI tests that this change is running into. |
Yes, unfortunately the P4-DPDK target is not stable. Trying to disable the tests here: #4228. |
No description provided.