Simplify jsonAssignment in ParserConverter and ActionConverter #4232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qobilidop FYI |
jafingerhut
approved these changes
Nov 9, 2023
|
Can't say this is fresh in my mind, but it looks reasonable. |
The inParser parameter is not actually used. I think it was introduced back when both converters shared the same implementation. Signed-off-by: Antonin Bas <antonin.bas@gmail.com>
antoninbas
force-pushed
the
simplify-jsonAssignment
branch
from
418a115 to
ff649dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The inParser parameter is not actually used. I think it was introduced back when both converters shared the same implementation.