Fix problem with bpftool in PTF tests #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PTF tests recently fail due to failing build of bpftool used for some test cases. Solution is to use latest release instead of HEAD of main branch. At least should work with bpftool v7.3.0
fruffy
reviewed
Dec 8, 2023
tools/ci-build.sh
Outdated
| git clone --recurse-submodules https://github.com/libbpf/bpftool.git /tmp/bpftool | ||
| # get tag for latest release, see https://docs.github.com/en/rest/releases/releases?apiVersion=2022-11-28#get-the-latest-release | ||
| BPFTOOL_RELEASE_TAG=$(curl -s https://api.github.com/repos/libbpf/bpftool/releases/latest | jq '.tag_name' | sed 's/\"//g') | ||
| git clone --recurse-submodules --branch "$BPFTOOL_RELEASE_TAG" https://github.com/libbpf/bpftool.git /tmp/bpftool |
There was a problem hiding this comment.
I would just fix this to https://github.com/libbpf/bpftool/releases/tag/v7.3.0 instead?
Building with the latest release could also easily lead to breakage.
There was a problem hiding this comment.
Building with the latest release could also easily lead to breakage.
Yes, you are right. After some additional research (made after this PR) I can say that fix to v7.3.0 will be the best solution.
fruffy
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTF tests recently fail due to failing build of bpftool used for some test cases. Solution is to use latest release instead of HEAD of main branch.
At least should work with bpftool v7.3.0