Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove uses of incompatible_use_toolchain_transition. #4299

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

katre
Copy link
Contributor

@katre katre commented Dec 18, 2023

Now that Bazel 7.0 has been released, it's time to remove this tech debt.

This has been a no-op since Bazel 5.0, I've been waiting to remove the code for two years, it's time.

Part of bazelbuild/bazel#14127.

@fruffy
Copy link
Collaborator

fruffy commented Dec 18, 2023

Fyi, Bazel is pinned to 6.4.0 here and here because of a (small) breaking change in 7.0. Happy to approve if that is not an issue.

@fruffy fruffy requested a review from smolkaj December 18, 2023 19:15
@katre
Copy link
Contributor Author

katre commented Dec 18, 2023

This is fine with Bazel 6.40, please merge.

Now that Bazel 7.0 has been released, it's time to remove this tech debt.

This has been a no-op since Bazel 5.0, I've been waiting to remove the code for
two years, it's time.

Part of bazelbuild/bazel#14127.
@fruffy fruffy force-pushed the remove-toolchain-transition branch from 0003a66 to 9f3aa76 Compare December 19, 2023 08:27
@fruffy fruffy merged commit e7b1125 into p4lang:main Dec 19, 2023
13 checks passed
@katre katre deleted the remove-toolchain-transition branch December 19, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants