Provide hints on how to fix CI complaints. #4355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomascalvert-xlnx
approved these changes
Jan 25, 2024
vlstill
previously requested changes
Jan 25, 2024
cmake/Linters.cmake
Outdated
| @@ -71,7 +71,7 @@ if(NOT ${CLANG_FORMAT_CMD}) | |||
| set(CLANG_FORMAT_CMD clang-format) | |||
| add_custom_target( | |||
| clang-format | |||
| COMMAND xargs -a ${CLANG_FORMAT_TXT_FILE} -r -d '\;' ${CLANG_FORMAT_CMD} --verbose --Werror --dry-run -i -- | |||
| COMMAND xargs -a ${CLANG_FORMAT_TXT_FILE} -r -d '\;' ${CLANG_FORMAT_CMD} --verbose --Werror --dry-run -i -- || echo ${RED}clang-format failed. Run \"make clang-format-fix-errors\" to fix the complaints.${COLOURRESET} | |||
There was a problem hiding this comment.
Hmm, wouldn't this hide the return code of check? Therefore the test would succeed even if a problem was found?
Putting the "request for changes" here mainly because this is already approved.
There was a problem hiding this comment.
Thanks for catching this. Getting sloppy recently...
fruffy
force-pushed
the
fruffy/ci_hints
branch
from
837dea3 to
8ad40e9
Compare
vlstill
approved these changes
Jan 26, 2024
vlstill
force-pushed
the
fruffy/ci_hints
branch
from
8ad40e9 to
ea7f727
Compare
|
(I've clicked the rebase button to unblock merging) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide some helpful hints on how to fix the linter complaints.