[P4Testgen] Add an option to override the test name. #4401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smolkaj
approved these changes
Feb 8, 2024
| @@ -90,6 +91,10 @@ class TestgenOptions : public AbstractP4cToolOptions { | |||
| /// Specifies minimum coverage that needs to be achieved for P4Testgen to exit successfully. | |||
| float minCoverage = 0; | |||
|
|
|||
| /// The base name of the tests which are generated. | |||
| /// Defaults to the name of the input program, if provided. | |||
| std::optional<cstring> testName; | |||
There was a problem hiding this comment.
Nit: If it is the base name, perhaps it would be good for the variable to be named accordingly? testBaseName?
fruffy
force-pushed
the
fruffy/testbackend_config
branch
from
5ac93fd to
81974aa
Compare
fruffy
force-pushed
the
fruffy/testname_override
branch
from
d2a5bb4 to
8e40efc
Compare
fruffy
force-pushed
the
fruffy/testbackend_config
branch
2 times, most recently
from
fd7c6d7 to
a50b982
Compare
fruffy
force-pushed
the
fruffy/testname_override
branch
from
8e40efc to
165f7dd
Compare
fruffy
force-pushed
the
fruffy/testname_override
branch
from
165f7dd to
18137ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.