Pass FrontEndPolicy to unit tests #4433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
added
run-ubuntu18
vlstill
force-pushed
the
fix-unittest-interface
branch
from
4163985 to
faa5e59
Compare
vlstill
requested review from
asl,
grg,
ChrisDodd,
fruffy,
smolkaj,
mihaibudiu and
kfcripps
fruffy
approved these changes
Feb 16, 2024
test/gtest/p4runtime.cpp
Outdated
| @@ -72,12 +72,22 @@ class ParseAnnotations : public P4::ParseAnnotations { | |||
| : P4::ParseAnnotations("FrontendTest", true, {PARSE("my_anno", StringLiteral)}) {} | |||
| }; | |||
|
|
|||
| struct AnnoFEP : P4::FrontEndPolicy { | |||
There was a problem hiding this comment.
Suggested change
| struct AnnoFEP : P4::FrontEndPolicy { | |
| struct AnnotationParsingPolicy : P4::FrontEndPolicy { |
|
I didn't see any breakage fwiw but this may affect the Tofino tests. |
It was also really easy with the old setting to accidentally test with side effects ordering disabled which I think is a mistake as presumably most of the backends will want it enabled. |
grg
pushed a commit
that referenced
this pull request
Apr 3, 2024
* Pass FrontEndPolicy to unit tests * Move now misplaced TODO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change (dev/test): Side-effects ordering is enabled in frontend tests (by #4406).
I've accidentally enabled side-effects ordering in all frontend tests throughout the code base in #4406 😢. I am sorry about this.
Arguably this could be a good thing (that is the indented use of the frotnend), but it could be surprising to downstream projects. Also, as the policy itself was not exposed, it was not possible to change this behaviour in downstream tests. This PR mitigates the second problem, it exposes frontend policy in tests so that tools can set it in any way they desire. The side-effects ordering is still enabled by default, which I think is a more reasonable default (it is the default used in frontend after all).
I don't see a way of ensuring downstream action on this without needlessly breaking interface of the tests that don't depend on either side effects ordering or annotation parsing. Therefore I just intend to ping people who I guess could be working on downstream projects here.