Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backends/tc: Fix issues reported in #4327 #4484

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

thomascalvert-xlnx
Copy link
Member

@vbnogueira @jhsmt @usha1830

See discussion in #4327 for context.

Copy link
Contributor

@usha1830 usha1830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@usha1830
Copy link
Contributor

@vbnogueira pls confirm that this solves the issue.
We can merge this PR after your confirmation

Copy link
Contributor

@vbnogueira vbnogueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and it seems to solve the issues

@usha1830 usha1830 added this pull request to the merge queue Feb 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 29, 2024
@thomascalvert-xlnx
Copy link
Member Author

Merge queue failed due to interim commit on main introducing unrelated changes to testdata.

Commits rebased and updated, @usha1830 could you please restart the merge?

@fruffy fruffy enabled auto-merge February 29, 2024 13:02
@fruffy fruffy added this pull request to the merge queue Feb 29, 2024
Merged via the queue into p4lang:main with commit dcae42a Feb 29, 2024
16 checks passed
@thomascalvert-xlnx thomascalvert-xlnx deleted the 4327-tc-fixes branch February 29, 2024 14:26
@fruffy fruffy added the p4tc Topics related to the P4-TC back end label Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p4tc Topics related to the P4-TC back end
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants