Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only emit the warning on EXPORT_COMPILE_COMMANDS when there are clang-tidy files to lint. #4665

Merged
merged 1 commit into from
May 17, 2024

Conversation

fruffy
Copy link
Collaborator

@fruffy fruffy commented May 16, 2024

Fix a warning that was caused by adding the clang-tidy linter. It pops ups because EXPORT_COMPILE_COMMANDS is disabled but we do not need it when there is nothing to lint.

@fruffy fruffy added the infrastructure Topics related to code style and build and test infrastructure. label May 16, 2024
@fruffy fruffy added this pull request to the merge queue May 17, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 17, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 17, 2024
@fruffy fruffy added this pull request to the merge queue May 17, 2024
Merged via the queue into main with commit 4a5fd99 May 17, 2024
17 checks passed
@fruffy fruffy deleted the fruffy/clang_tidy_warning branch May 17, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Topics related to code style and build and test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants