[P4Tools] Clean up the P4Tools GTest infrastructure. #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fruffy
force-pushed
the
fruffy/p4tools_test_cleanup
branch
4 times, most recently
from
a518cd4 to
54528ee
Compare
fruffy
force-pushed
the
fruffy/p4tools_test_cleanup
branch
from
54528ee to
368e18f
Compare
vlstill
reviewed
Aug 15, 2024
backends/p4tools/modules/testgen/targets/bmv2/test/gtest_utils.h
Outdated
Show resolved
Hide resolved
| using namespace P4::literals; | ||
|
|
||
| class P4AssertsParserTest : public P4ToolsTest {}; | ||
| class P4AssertsParserTest : public ::testing::Test {}; |
There was a problem hiding this comment.
Is there a conflict on the testing namespace? Or why use the global marker ::?
There was a problem hiding this comment.
I believe this is an artifact of other tests using ::testing::Test and things getting copied as needed.
Eg., https://github.com/p4lang/p4c/blob/main/test/gtest/bitrange.cpp#L37
I can clean these up to testing::Test, if desired.
backends/p4tools/modules/testgen/targets/bmv2/test/gtest_utils.h
Outdated
Show resolved
Hide resolved
vlstill
approved these changes
Aug 27, 2024
Signed-off-by: fruffy <fruffy@nyu.edu>
Signed-off-by: fruffy <fruffy@nyu.edu>
fruffy
force-pushed
the
fruffy/p4tools_test_cleanup
branch
from
51dcdb2 to
4957d6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up some of the P4Testgen Gtest infrastructure
P4Tools::Testnamespace to reduce some namespace clutter.Prerequisite for #4787.