Lazily initialize cstring cache. #4866
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cstrings could be statically constructed (e.g. via cstring literals) but this requires cstring cache to be already alive. The order of static ctors is not defined, so we need to ensure cstring cache is already there on the first use Signed-off-by: Anton Korobeynikov <anton@korobeynikov.info>
asl
added
the
core
|
Should be more complete solution compared to #4865 |
qobilidop
approved these changes
Aug 12, 2024
fruffy
approved these changes
Aug 12, 2024
ChrisDodd
reviewed
Aug 12, 2024
| static CacheType *g_cache = nullptr; | ||
| if (!g_cache) g_cache = new CacheType; | ||
|
|
||
| return *g_cache; |
There was a problem hiding this comment.
static locals are defined to be initialized the first time the containing function is called, so there's no need to do this.
There was a problem hiding this comment.
Hrm, you are right, this is a local, not global. Then I need to check what was going on for the original case...
|
Closing for now to investigate the original case again (see #4866 (comment) for more information). Will reopen with updated information what was going on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cstrings could be statically constructed (e.g. via cstring literals) but this requires cstring cache to be already alive.
The order of static ctors is not defined, so we need to ensure cstring cache is already there on the first use