Add Vector::dbprint #4943
Merged
Add Vector::dbprint #4943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlstill
force-pushed
the
vstill/ivector-dbprint
branch
from
d85b5bf to
4d87566
Compare
vlstill
added
the
core
vlstill
force-pushed
the
vstill/ivector-dbprint
branch
from
2021965 to
bd90dbe
Compare
|
The STF failures come from the comment not being escaped properly because the generated string has a newline and STF does not support multi-line comments. It would be nice to fix this. The current workaround is to remove newlines for writing there: |
vlstill
force-pushed
the
vstill/ivector-dbprint
branch
from
c989de7 to
b6648dc
Compare
Signed-off-by: Vladimír Štill <vladimir.still@intel.com>
vlstill
force-pushed
the
vstill/ivector-dbprint
branch
2 times, most recently
from
4d07e85 to
7661bb5
Compare
Signed-off-by: Vladimír Štill <git@vstill.eu>
fruffy
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IR::VectorandIR::IndexedVectorare often used in other IR nodes (such usBlockStatementorP4Control), and therefore is often processed by passes. However, up until now it had only un-useful default debug printer. This PR adds simple debug printer for indexed vector. It is mainly useful in debugger, in tests to add context to failed assertion, or inLOG*functions.