Fix FlattenLogMsg not properly working on nested structures #5036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
|
This changes some reference files, which need to be updated by adding |
fruffy
added
the
core
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
jhavrane
force-pushed
the
jhavrane/fix_log_msg_struct
branch
from
e21ccc3 to
43bf35b
Compare
|
Done. Updated reference files. Adding new pass to p4test's midend required a minor fix in ToP4 pass, which was not dumping |
fruffy
reviewed
Dec 2, 2024
asl
reviewed
Dec 2, 2024
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
jafingerhut
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
Approving based on my review of the new test P4 program, and the updated expected outputs of one of the existing test programs. My review does not include the C++ implementation code changes. Please wait for someone else's review on that part of this PR before merging.
asl
reviewed
Dec 4, 2024
Signed-off-by: Jiri Havranek <jiri.havranek@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5035.
Adds FlattenLogMsg to p4test/midend to test this.