Small fixes for p4tc #5097
Merged
Small fixes for p4tc #5097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vbnogueira
commented
Jan 14, 2025
•
vbnogueira
commented
- Convert IPv4 and IPv6 protocol values to network order before comparison
- Update pna.h
- Zero initialise compiler_meta__->egress_port
|
@komaljai please take a look when you have some time |
vbnogueira
force-pushed
the
small_fixes_for_p4tc
branch
from
6fcff63 to
75cef15
Compare
Convert IPv4 and IPv6 protocol values to network order before comparison Signed-off-by: Victor Nogueira <victor@mojatatu.com>
Update pna.h and fix some whitespaces Signed-off-by: Victor Nogueira <victor@mojatatu.com>
In some cases, the skb may have put rubbish in the skb->cb When this happens, egress_port may be different then zero and end up causing an accidental redirect Fix this by initialising it to zero at the start of the entrypoint function Signed-off-by: Victor Nogueira <victor@mojatatu.com>
vbnogueira
force-pushed
the
small_fixes_for_p4tc
branch
from
75cef15 to
af007ba
Compare
komaljai
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.