Fixed JTextArea Bug on mac and updated buttons #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for this @jdrysdaleandesrson! |
|
This is how it looks like. No huge changes but it works now on mac without issues.
|
pH-7
reviewed
Apr 22, 2023
src/simplejavacalculator/UI.java
Outdated
| butSquare = new JButton("x*x"); | ||
| butOneDividedBy = new JButton("1/x"); | ||
| butEqual = new JButton("="); | ||
| butSquareRoot = new JButton("<html>√x</html>"); |
There was a problem hiding this comment.
Could we avoid having html tags inside JButton…?
I wonder if there is any alternatives?
|
Hope you are keeping well! @jdrysdaleandesrson, I'm assigning you to your PR, so you can finish addressing the comment I've left 🙂 |
changed the html tags to unicode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS the JTextArea for the "text" was too wide and made it so the user could not see the numbers being inputed as they were off the frame. Also, updated button symbols with super scripts.