Inject GIT_BRANCH and GIT_COMMIT_SHA in env #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@b4nst Thanks for the PR! I just realized I never set up a proper linter, and your style is different so the PR is actually quite big. Would you mind rebasing this and updating your dependencies and running |
|
Wow woops ! Didn't check the diff before creating the PR 😖. My bad, of course I don't mind rebasing and cleaning. Will do today. |
|
Hey folks, any update on this? |
paambaati
approved these changes
Aug 28, 2019
|
Sorry I missed this! This fix just landed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the doc code climate needs some env var to set the branch and SHA properly. Unfortunately the variable names set by GitHub Action are unsupported.
codeclimate/test-reporter#402 will address the problem.
Until that I've made this changes to works with the current test-reporter version.
Up to you to merge or wait for the test-reporter to be compliant with Action.