fix(frontend): stop using chain function from lodash-es as it does no…

…t support tree shaking
pablolmedorado · Apr 5, 2022 · dcae903 · dcae903
1 parent c83e6ac
commit dcae903
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 24 deletions.
diff --git a/frontend/src/modules/breakfasts/components/dialogs/BreakfastSummaryDialog.vue b/frontend/src/modules/breakfasts/components/dialogs/BreakfastSummaryDialog.vue
@@ -43,7 +43,7 @@
 <script>
 import { computed, ref } from "@vue/composition-api";
 import { useClipboard } from "@vueuse/core";
-import { chain, property, uniqueId } from "lodash-es";
+import { countBy, map, pick, uniqueId } from "lodash-es";
 
 import { useMainStore } from "@/stores/main";
 import useDialog, { dialogProps } from "@/composables/useDialog";
@@ -86,21 +86,21 @@ export default {
 
     // Computed
     const itemSummary = computed(() => {
-      return chain(items.value)
-        .map((item) => chain(item).pick(["bread", "base", "ingredient1", "ingredient2"]).map(property("name")).value())
-        .countBy()
-        .map((count, item) => {
-          const elements = item.split(",");
-          return {
-            id: uniqueId("breakfast_"),
-            bread: elements[0] || "",
-            base: elements[1] || "",
-            ingredient1: elements[2] || "",
-            ingredient2: elements[3] || "",
-            count,
-          };
-        })
-        .value();
+      const rawBreakfasts = items.value.map((breakfast) =>
+        map(pick(breakfast, ["bread", "base", "ingredient1", "ingredient2"]), "name")
+      );
+      const breakfastsByCount = countBy(rawBreakfasts);
+      return map(breakfastsByCount, (count, item) => {
+        const elements = item.split(",");
+        return {
+          id: uniqueId("breakfast_"),
+          bread: elements[0] || "",
+          base: elements[1] || "",
+          ingredient1: elements[2] || "",
+          ingredient2: elements[3] || "",
+          count,
+        };
+      });
     });
     const clipboardSummary = computed(() => {
       return itemSummary.value

diff --git a/frontend/src/modules/holidays/components/dialogs/HolidaysDetailDialog.vue b/frontend/src/modules/holidays/components/dialogs/HolidaysDetailDialog.vue
@@ -28,7 +28,7 @@
 
 <script>
 import { computed, ref } from "@vue/composition-api";
-import { chain } from "lodash-es";
+import { countBy, map } from "lodash-es";
 
 import useDialog, { dialogProps } from "@/composables/useDialog";
 
@@ -61,13 +61,11 @@ export default {
 
     // Computed
     const holidaysSummary = computed(() => {
-      return chain(holidays.value)
-        .countBy((item) => [item.allowance_date, item.expiration_date])
-        .map((count, item) => {
-          const dates = item.split(",");
-          return { allowance_date: dates[0], expiration_date: dates[1], count };
-        })
-        .value();
+      const holidaysByCount = countBy(holidays.value, (item) => [item.allowance_date, item.expiration_date]);
+      return map(holidaysByCount, (count, item) => {
+        const dates = item.split(",");
+        return { allowance_date: dates[0], expiration_date: dates[1], count };
+      });
     });
 
     // Methods